From 41639d5dd7c9b8b272e615435fa7e2707998a478 Mon Sep 17 00:00:00 2001
From: smallNorthLee <18210040298@163.com>
Date: Tue, 18 Mar 2025 19:12:39 +0800
Subject: [PATCH] =?UTF-8?q?review:=20=E9=87=8D=E6=9E=84=E7=BB=84=E8=A3=85?=
 =?UTF-8?q?=E4=B8=8B=E4=B8=80=E4=B8=AA=E8=8A=82=E7=82=B9=E5=AE=A1=E6=89=B9?=
 =?UTF-8?q?=E4=BA=BA=E6=96=B9=E6=B3=95?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../service/task/BpmProcessInstanceServiceImpl.java   | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/yudao-module-bpm/yudao-module-bpm-biz/src/main/java/cn/iocoder/yudao/module/bpm/service/task/BpmProcessInstanceServiceImpl.java b/yudao-module-bpm/yudao-module-bpm-biz/src/main/java/cn/iocoder/yudao/module/bpm/service/task/BpmProcessInstanceServiceImpl.java
index 7fd065e833..f987620802 100644
--- a/yudao-module-bpm/yudao-module-bpm-biz/src/main/java/cn/iocoder/yudao/module/bpm/service/task/BpmProcessInstanceServiceImpl.java
+++ b/yudao-module-bpm/yudao-module-bpm-biz/src/main/java/cn/iocoder/yudao/module/bpm/service/task/BpmProcessInstanceServiceImpl.java
@@ -267,7 +267,6 @@ public class BpmProcessInstanceServiceImpl implements BpmProcessInstanceService
         FlowElement flowElement = bpmnModel.getFlowElement(task.getTaskDefinitionKey());
         List<FlowNode> nextFlowNodes = BpmnModelUtils.getNextFlowNodes(flowElement, bpmnModel, processVariables);
 
-        // TODO @小北：还是可以优化下哈；“4. 组装节点信息” 只拼接出 candidateUserIds；之后，再第二次循环，查询用户和部门信息，进行拼接
         // 2. 收集所有节点的候选用户 ID
         Set<Long> allCandidateUsers = new HashSet<>();
         for (FlowNode node : nextFlowNodes) {
@@ -287,13 +286,13 @@ public class BpmProcessInstanceServiceImpl implements BpmProcessInstanceService
                     loginUserId, historicProcessInstance.getProcessDefinitionId(), processVariables);
 
             // 4.2 组装候选用户信息
-            List<UserSimpleBaseVO> candidateUsers = new ArrayList<>();
-            for (Long userId : candidateUserIds) {
-                UserSimpleBaseVO user = BpmProcessInstanceConvert.INSTANCE.buildUser(userId, userMap, deptMap);
+            List<UserSimpleBaseVO> candidateUsers = convertList(candidateUserIds, userId -> {
+                AdminUserRespDTO user = userMap.get(userId);
                 if (user != null) {
-                    candidateUsers.add(user);
+                    return BpmProcessInstanceConvert.INSTANCE.buildUser(userId, userMap, deptMap);
                 }
-            }
+                return null;
+            });
 
             // 4.3 构建节点信息
             return new ActivityNode()