【代码评审】IoT:清理流程的实例们

This commit is contained in:
YunaiV 2025-01-23 20:08:31 +08:00
parent 281d3d1d53
commit 846d0605d8
3 changed files with 5 additions and 11 deletions

View File

@ -7,8 +7,6 @@ import cn.iocoder.yudao.module.bpm.controller.admin.task.vo.instance.BpmProcessI
import cn.iocoder.yudao.module.bpm.dal.dataobject.task.BpmProcessInstanceCopyDO; import cn.iocoder.yudao.module.bpm.dal.dataobject.task.BpmProcessInstanceCopyDO;
import org.apache.ibatis.annotations.Mapper; import org.apache.ibatis.annotations.Mapper;
import java.util.List;
@Mapper @Mapper
public interface BpmProcessInstanceCopyMapper extends BaseMapperX<BpmProcessInstanceCopyDO> { public interface BpmProcessInstanceCopyMapper extends BaseMapperX<BpmProcessInstanceCopyDO> {
@ -20,12 +18,8 @@ public interface BpmProcessInstanceCopyMapper extends BaseMapperX<BpmProcessInst
.orderByDesc(BpmProcessInstanceCopyDO::getId)); .orderByDesc(BpmProcessInstanceCopyDO::getId));
} }
default List<BpmProcessInstanceCopyDO> selectListByProcessInstanceIdAndActivityId(String processInstanceId, String activityId) {
return selectList(BpmProcessInstanceCopyDO::getProcessInstanceId, processInstanceId,
BpmProcessInstanceCopyDO::getActivityId, activityId);
}
default void deleteByProcessInstanceId(String processInstanceId) { default void deleteByProcessInstanceId(String processInstanceId) {
delete(BpmProcessInstanceCopyDO::getProcessInstanceId, processInstanceId); delete(BpmProcessInstanceCopyDO::getProcessInstanceId, processInstanceId);
} }
} }

View File

@ -288,9 +288,8 @@ public class BpmModelServiceImpl implements BpmModelService {
// 2.3 清理所有 Task // 2.3 清理所有 Task
List<Task> tasks = taskService.createTaskQuery() List<Task> tasks = taskService.createTaskQuery()
.processDefinitionKey(model.getKey()).list(); .processDefinitionKey(model.getKey()).list();
tasks.forEach(task -> { // TODO @lesan貌似传递一个 reason 会好点
taskService.deleteTask(task.getId()); tasks.forEach(task -> taskService.deleteTask(task.getId()));
});
} }
@Override @Override

View File

@ -53,7 +53,8 @@ public interface BpmProcessInstanceCopyService {
/** /**
* 删除抄送流程 * 删除抄送流程
* *
* @param processInstanceId 流程实例id * @param processInstanceId 流程实例 ID
*/ */
void deleteProcessInstanceCopy(String processInstanceId); void deleteProcessInstanceCopy(String processInstanceId);
} }