szz
/
ShiShiYiBan
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

【代码评审】BPM：触发器 - 表单修改

This commit is contained in:
YunaiV 2025-02-09 06:55:56 +08:00
parent f5050807e1
commit 9569c3fbed
5 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
yudao-framework/yudao-common/src/main/java/cn/iocoder/yudao/framework/common/util/json/JsonUtils.java
View File

@ -206,4 +206,5 @@ public class JsonUtils {
public static boolean isJsonObject(String str) { public static boolean isJsonObject(String str) {
return JSONUtil.isTypeJSONObject(str); return JSONUtil.isTypeJSONObject(str);
} }
} }

3
yudao-module-bpm/yudao-module-bpm-api/src/main/java/cn/iocoder/yudao/module/bpm/enums/definition/BpmTriggerTypeEnum.java
View File

@ -17,8 +17,7 @@ import java.util.Arrays;
public enum BpmTriggerTypeEnum implements ArrayValuable<Integer> { public enum BpmTriggerTypeEnum implements ArrayValuable<Integer> {
HTTP_REQUEST(1, "发起 HTTP 请求"), HTTP_REQUEST(1, "发起 HTTP 请求"),
UPDATE_NORMAL_FORM(2, "更新流程表单"); UPDATE_NORMAL_FORM(2, "更新流程表单"); // TODO @jason：FORM_UPDATE
/** /**
* 触发器执行动作类型 * 触发器执行动作类型

5
yudao-module-bpm/yudao-module-bpm-biz/src/main/java/cn/iocoder/yudao/module/bpm/controller/admin/definition/vo/model/simple/BpmSimpleModelNodeVO.java
View File

@ -345,6 +345,8 @@ public class BpmSimpleModelNodeVO {
@Valid @Valid
private HttpRequestTriggerSetting httpRequestSetting; private HttpRequestTriggerSetting httpRequestSetting;
// TODO @jason：这个要不直接叫 formSetting，更好理解一点哈
// TODO @jason：如果搞成 List<NormalFormTriggerSetting>，是不是可以做条件组了？微信讨论哈
/** /**
* 流程表单触发器设置 * 流程表单触发器设置
*/ */
@ -376,6 +378,7 @@ public class BpmSimpleModelNodeVO {
*/ */
@Schema(description = "请求返回处理设置", example = "[]") @Schema(description = "请求返回处理设置", example = "[]")
private List<KeyValue<String, String>> response; private List<KeyValue<String, String>> response;
} }
@Schema(description = "流程表单触发器设置", example = "{}") @Schema(description = "流程表单触发器设置", example = "{}")
@ -384,6 +387,8 @@ public class BpmSimpleModelNodeVO {
@Schema(description = "修改的表单字段", example = "userName") @Schema(description = "修改的表单字段", example = "userName")
private Map<String, Object> updateFormFields; private Map<String, Object> updateFormFields;
} }
} }
} }

7
yudao-module-bpm/yudao-module-bpm-biz/src/main/java/cn/iocoder/yudao/module/bpm/service/task/trigger/BpmHttpRequestTrigger.java
View File

@ -81,13 +81,14 @@ public class BpmHttpRequestTrigger implements BpmTrigger {
} }
// 4.1 判断是否需要解析返回值 // 4.1 判断是否需要解析返回值
if (StrUtil.isEmpty(responseEntity.getBody()) || !responseEntity.getStatusCode().is2xxSuccessful() if (StrUtil.isEmpty(responseEntity.getBody())
|| !responseEntity.getStatusCode().is2xxSuccessful()
|| CollUtil.isEmpty(setting.getResponse())) { || CollUtil.isEmpty(setting.getResponse())) {
return; return;
} }
// 4.2 解析返回值, 返回值必须符合 CommonResult 规范。 // 4.2 解析返回值, 返回值必须符合 CommonResult 规范。
CommonResult<Map<String, Object>> respResult = JsonUtils.parseObjectQuietly(responseEntity.getBody(), CommonResult<Map<String, Object>> respResult = JsonUtils.parseObjectQuietly(
new TypeReference<>() {}); responseEntity.getBody(), new TypeReference<>() {});
if (respResult == null || !respResult.isSuccess()){ if (respResult == null || !respResult.isSuccess()){
return; return;
} }

2
yudao-module-bpm/yudao-module-bpm-biz/src/main/java/cn/iocoder/yudao/module/bpm/service/task/trigger/BpmUpdateNormalFormTrigger.java
View File

@ -9,6 +9,7 @@ import jakarta.annotation.Resource;
import lombok.extern.slf4j.Slf4j; import lombok.extern.slf4j.Slf4j;
import org.springframework.stereotype.Component; import org.springframework.stereotype.Component;
// TODO @jason：改成 BpmFormUpdateTrigger
/** /**
* BPM 更新流程表单触发器 * BPM 更新流程表单触发器
* *
@ -39,4 +40,5 @@ public class BpmUpdateNormalFormTrigger implements BpmTrigger {
processInstanceService.updateProcessInstanceVariables(processInstanceId, setting.getUpdateFormFields()); processInstanceService.updateProcessInstanceVariables(processInstanceId, setting.getUpdateFormFields());
} }
} }
} }