szz
/
ShiShiYiBan
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

【功能修复】工作流：延迟器 trigger 时，租户 id 丢失的问题

This commit is contained in:
YunaiV 2025-01-03 19:52:51 +08:00
parent b48052a5f5
commit e380bc34f3
3 changed files with 36 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
yudao-module-bpm/yudao-module-bpm-biz/src/main/java/cn/iocoder/yudao/module/bpm/framework/flowable/core/candidate/BpmTaskCandidateInvoker.java
View File

@ -12,6 +12,7 @@ import cn.iocoder.yudao.module.bpm.enums.definition.BpmUserTaskApproveTypeEnum;
import cn.iocoder.yudao.module.bpm.enums.definition.BpmUserTaskAssignStartUserHandlerTypeEnum; import cn.iocoder.yudao.module.bpm.enums.definition.BpmUserTaskAssignStartUserHandlerTypeEnum;
import cn.iocoder.yudao.module.bpm.framework.flowable.core.enums.BpmTaskCandidateStrategyEnum; import cn.iocoder.yudao.module.bpm.framework.flowable.core.enums.BpmTaskCandidateStrategyEnum;
import cn.iocoder.yudao.module.bpm.framework.flowable.core.util.BpmnModelUtils; import cn.iocoder.yudao.module.bpm.framework.flowable.core.util.BpmnModelUtils;
import cn.iocoder.yudao.module.bpm.framework.flowable.core.util.FlowableUtils;
import cn.iocoder.yudao.module.bpm.service.task.BpmProcessInstanceService; import cn.iocoder.yudao.module.bpm.service.task.BpmProcessInstanceService;
import cn.iocoder.yudao.module.system.api.user.AdminUserApi; import cn.iocoder.yudao.module.system.api.user.AdminUserApi;
import cn.iocoder.yudao.module.system.api.user.dto.AdminUserRespDTO; import cn.iocoder.yudao.module.system.api.user.dto.AdminUserRespDTO;
@ -91,35 +92,39 @@ public class BpmTaskCandidateInvoker {
*/ */
@DataPermission(enable = false) // 忽略数据权限，避免因为过滤，导致找不到候选人 @DataPermission(enable = false) // 忽略数据权限，避免因为过滤，导致找不到候选人
public Set<Long> calculateUsersByTask(DelegateExecution execution) { public Set<Long> calculateUsersByTask(DelegateExecution execution) {
// 审批类型非人工审核时，不进行计算候选人。原因是：后续会自动通过、不通过 // 注意：解决极端情况下，Flowable 异步调用，导致租户 id 丢失的情况
FlowElement flowElement = execution.getCurrentFlowElement(); // 例如说，SIMPLE 延迟器在 trigger 的时候！！！
Integer approveType = BpmnModelUtils.parseApproveType(flowElement); return FlowableUtils.execute(execution.getTenantId(), () -> {
if (ObjectUtils.equalsAny(approveType, // 审批类型非人工审核时，不进行计算候选人。原因是：后续会自动通过、不通过
BpmUserTaskApproveTypeEnum.AUTO_APPROVE.getType(), FlowElement flowElement = execution.getCurrentFlowElement();
BpmUserTaskApproveTypeEnum.AUTO_REJECT.getType())) { Integer approveType = BpmnModelUtils.parseApproveType(flowElement);
return new HashSet<>(); if (ObjectUtils.equalsAny(approveType,
} BpmUserTaskApproveTypeEnum.AUTO_APPROVE.getType(),
BpmUserTaskApproveTypeEnum.AUTO_REJECT.getType())) {
return new HashSet<>();
}
// 1.1 计算任务的候选人 // 1.1 计算任务的候选人
Integer strategy = BpmnModelUtils.parseCandidateStrategy(flowElement); Integer strategy = BpmnModelUtils.parseCandidateStrategy(flowElement);
String param = BpmnModelUtils.parseCandidateParam(flowElement); String param = BpmnModelUtils.parseCandidateParam(flowElement);
Set<Long> userIds = getCandidateStrategy(strategy).calculateUsersByTask(execution, param); Set<Long> userIds = getCandidateStrategy(strategy).calculateUsersByTask(execution, param);
// 1.2 移除被禁用的用户 // 1.2 移除被禁用的用户
removeDisableUsers(userIds); removeDisableUsers(userIds);
// 2. 候选人为空时，根据“审批人为空”的配置补充 // 2. 候选人为空时，根据“审批人为空”的配置补充
if (CollUtil.isEmpty(userIds)) { if (CollUtil.isEmpty(userIds)) {
userIds = getCandidateStrategy(BpmTaskCandidateStrategyEnum.ASSIGN_EMPTY.getStrategy()) userIds = getCandidateStrategy(BpmTaskCandidateStrategyEnum.ASSIGN_EMPTY.getStrategy())
.calculateUsersByTask(execution, param); .calculateUsersByTask(execution, param);
// ASSIGN_EMPTY 策略，不需要移除被禁用的用户。原因是，再移除，可能会出现更没审批人了！！！ // ASSIGN_EMPTY 策略，不需要移除被禁用的用户。原因是，再移除，可能会出现更没审批人了！！！
} }
// 3. 移除发起人的用户 // 3. 移除发起人的用户
ProcessInstance processInstance = SpringUtil.getBean(BpmProcessInstanceService.class) ProcessInstance processInstance = SpringUtil.getBean(BpmProcessInstanceService.class)
.getProcessInstance(execution.getProcessInstanceId()); .getProcessInstance(execution.getProcessInstanceId());
Assert.notNull(processInstance, "流程实例({}) 不存在", execution.getProcessInstanceId()); Assert.notNull(processInstance, "流程实例({}) 不存在", execution.getProcessInstanceId());
removeStartUserIfSkip(userIds, flowElement, Long.valueOf(processInstance.getStartUserId())); removeStartUserIfSkip(userIds, flowElement, Long.valueOf(processInstance.getStartUserId()));
return userIds; return userIds;
});
} }
public Set<Long> calculateUsersByActivity(BpmnModel bpmnModel, String activityId, public Set<Long> calculateUsersByActivity(BpmnModel bpmnModel, String activityId,

3
yudao-module-bpm/yudao-module-bpm-biz/src/main/java/cn/iocoder/yudao/module/bpm/framework/flowable/core/util/SimpleModelUtils.java
View File

@ -628,8 +628,7 @@ public class SimpleModelUtils {
TimerEventDefinition eventDefinition = new TimerEventDefinition(); TimerEventDefinition eventDefinition = new TimerEventDefinition();
if (node.getDelaySetting().getDelayType().equals(BpmDelayTimerType.FIXED_DATE_TIME.getType())){ if (node.getDelaySetting().getDelayType().equals(BpmDelayTimerType.FIXED_DATE_TIME.getType())){
eventDefinition.setTimeDuration(node.getDelaySetting().getDelayTime()); eventDefinition.setTimeDuration(node.getDelaySetting().getDelayTime());
} } else if (node.getDelaySetting().getDelayType().equals(BpmDelayTimerType.FIXED_TIME_DURATION.getType())){
if (node.getDelaySetting().getDelayType().equals(BpmDelayTimerType.FIXED_TIME_DURATION.getType())){
eventDefinition.setTimeDate(node.getDelaySetting().getDelayTime()); eventDefinition.setTimeDate(node.getDelaySetting().getDelayTime());
} }
boundaryEvent.addEventDefinition(eventDefinition); boundaryEvent.addEventDefinition(eventDefinition);

9
yudao-module-bpm/yudao-module-bpm-biz/src/main/java/cn/iocoder/yudao/module/bpm/service/task/BpmTaskServiceImpl.java
View File

@ -1246,15 +1246,14 @@ public class BpmTaskServiceImpl implements BpmTaskService {
.activityId(taskDefineKey) .activityId(taskDefineKey)
.singleResult(); .singleResult();
if (execution == null) { if (execution == null) {
log.error("[processDelayTimerTimeout][processInstanceId({})activityId({}) 没有找到执行活动]", log.error("[processDelayTimerTimeout][processInstanceId({}) activityId({}) 没有找到执行活动]",
processInstanceId, taskDefineKey); processInstanceId, taskDefineKey);
return; return;
} }
// 若存在直接触发接收任务，执行后续节点 // 若存在直接触发接收任务，执行后续节点
// TODO @芋艿 这里需要帮助看一下，我不懂为啥开启了租户后就一直报错：不存在租户编号 FlowableUtils.execute(execution.getTenantId(),
FlowableUtils.execute(execution.getTenantId(), () -> { () -> runtimeService.trigger(execution.getId()));
runtimeService.trigger(execution.getId());
});
} }
/** /**